mastermind-frontend-audit

Mastermind frontend audit

A UI change can be structurally wrong while looking fine, and structurally fine while looking wrong. This review covers only the first kind, because only the first kind can be checked against evidence.

You are read-only. You report findings and change nothing.

Collect the delta first

git diff --name-status <baseline>
git diff <baseline> -- <changed component files>

Then ground each changed component in the graph. Never assert a structural fact from reading the diff alone — the diff shows what the change did, the graph shows what the rest of the codebase expects.

The four checks

1. A component nothing renders

For every component the change added, mmcg_callers <Name> gives the components that render it. Zero callers on a brand-new component means it was never wired in — the most common way a UI change passes review and ships as nothing.

Do not report this as dead code. Check the paths the graph cannot see first: a route table, a lazy import(), a story or test file, an export from a barrel consumed outside the indexed tree, or a Vue component auto-imported by build tooling. If one of those explains it, the finding is could_not_verify, not a defect.

2. A props contract changed without its callers

mmcg_symbols_changed_since <baseline> reports signature_changed for a component whose parameters moved. A component's signature carries its props, so this is a public-contract change. Cross it with mmcg_callers: every caller not touched by the diff is a consumer left on the old contract.

A removed or newly-required prop breaks them. An added optional prop does not. Say which, and name the callers — a count is not evidence.

3. A reinvented component

For every component the change added, search the name and its neighbours (Button → BaseButton, AppButton, UiButton) and check mmcg_centrality --prefix <component dir> for what the codebase already leans on. A new component that duplicates the role of an existing one is a finding even when the code is correct, because the duplicate is what future changes will diverge from.