testing-patterns

SOVA Testing Patterns

When writing or modifying files in tests/, follow these conventions. Reference: docs/testing-guidelines.md.

Framework

• asyncio_mode = "auto" -- no @pytest.mark.asyncio needed on async tests
• All tests flat in tests/ -- no subdirectories, no conftest.py
• Tests grouped with classes. Fixtures defined per-file, not shared.

Required Fixtures

In-memory DB (autouse in any file touching ORM):

@pytest.fixture(autouse=True)
async def setup_db():
    os.environ["SOVA_DATABASE_URL"] = "sqlite+aiosqlite://"
    await init_db(run_migrations=False)
    yield
    await close_db()
    os.environ.pop("SOVA_DATABASE_URL", None)

Dashboard client:

@pytest.fixture
async def client(tmp_path):
    app = create_app(project_dir=tmp_path)
    transport = ASGITransport(app=app)
    async with AsyncClient(transport=transport, base_url="http://test") as ac:
        yield ac

Mock Rules

1. Patch at the import site, not the definition site:

   # Correct
   patch("sova.adapters.github.run", new_callable=AsyncMock)
   # Wrong
   patch("sova.utils.shell.run", new_callable=AsyncMock)
   

2. Use patch.object for split modules -- patch the actual submodule, not the re-export facade:

   patch.object(agent_lifecycle, "_get_project_agents", return_value=pa)
   

3. ShellResult factory -- define per-file:

   def _shell_result(stdout="", stderr="", returncode=0):
       return ShellResult(returncode=returncode, stdout=stdout, stderr=stderr)
   

4. Context factory -- define per-file:

   def _make_ctx(**kwargs) -> ExecutionContext:
       defaults = {"project_dir": Path("/tmp/test"), "config": ProjectConfig(),
                   "adapter": _mock_adapter(), "issue_number": "42", "role": "developer"}
       defaults.update(kwargs)
       return ExecutionContext(**defaults)
   

5. Multi-call methods: use side_effect list.

Pitfalls