sova: Skill for Claude Code

SOVA Testing Patterns

When writing or modifying files in tests/, follow these conventions. Reference: docs/testing-guidelines.md.

Framework

• asyncio_mode = "auto": no @pytest.mark.asyncio needed on async tests
• All tests flat in tests/: no subdirectories, no conftest.py
• Tests grouped with classes. Fixtures defined per-file, not shared.

Required Fixtures

In-memory DB (autouse in any file touching ORM):

@pytest.fixture(autouse=True)
async def setup_db(monkeypatch):
    monkeypatch.setenv("SOVA_DATABASE_URL", "sqlite+aiosqlite://")
    await init_db(run_migrations=False)
    yield
    await close_db()

Dashboard client:

@pytest.fixture
async def client(tmp_path):
    app = create_app(project_dir=tmp_path)
    transport = ASGITransport(app=app)
    async with AsyncClient(transport=transport, base_url="http://test") as ac:
        yield ac

Mock Rules

1. Patch at the import site, not the definition site:

   # Correct
   patch("sova.adapters.github.run", new_callable=AsyncMock)
   # Wrong
   patch("sova.utils.shell.run", new_callable=AsyncMock)
   

   Exception: when the code under test imports inside the function body (from x import y in the function), there is no module-level binding to patch, so patch the source module (x.y). Leave a one-line comment at the patch site so a reviewer does not "fix" it back.

1b. Environment variables: always monkeypatch.setenv/delenv, never assign to or pop from os.environ directly. A direct mutation outlives a failing test and leaks into every later test in the process.

1. Use patch.object for split modules: patch the actual submodule, not the re-export facade:

   patch.object(agent_lifecycle, "_get_project_agents", return_value=pa)
   

2. ShellResult factory: define per-file:

   def _shell_result(stdout="", stderr="", returncode=0):
       return ShellResult(returncode=returncode, stdout=stdout, stderr=stderr)