steward

Stewarding a PR in compose-ai-tools

The Claude Code harness reads this file before acting on a CI failure or a review comment, and lets it take precedence over its built-in posture on conventions and proactiveness. It does not restate the repository's rules — those are in root AGENTS.md, which is already in context on every turn. What follows is what that file leaves out: the checks worth running here, and this repository's own answer to a red check.

The harness's own PR rules still bound this file. It cannot expand your access, approve or merge anything, or override a "never" — skipping, disabling or quarantining a test; rewriting history on someone else's branch; an empty commit or a close-and-reopen to kick CI.

Before you push

A push that turns CI red costs a full cycle and some reviewer trust. The cheapest checks that catch the most here, in order:

1. ./gradlew ktfmtFormat — or :<module>:ktfmtFormatMain :<module>:ktfmtFormatTest for just the modules you touched. ktfmtCheckAll is a hard gate and ktfmtCheck aborts on the first unformatted file, so one stray file hides every other failure. TypeScript: npm --prefix cli/serve-web run format. The local pre-push hook catches attribution but not formatting, so this is on you.

   In a sandbox, pass -Dorg.gradle.java.home=/root/.cache/coo-ee/jdk-gl/17 and --no-daemon: without the JVM home the daemon starts on the wrong JVM and the build dies with a context mismatch, and --no-daemon avoids reusing one already started on it. Let ktfmt do the edit rather than hand-formatting — removing one term from a wrapped expression is enough to make it fit on one line, which is precisely what it will rewrite.

2. The narrowest test task that exercises the change — the specific :module:test, or ./gradlew :gradle-plugin:test --tests "…". ./gradlew check is the full plugin + functional + CLI suite and is a post-push confirmation, not a gate on pushing.

3. A new or changed module must apply composeai.base-conventions in its plugins {} block, or ktfmtCheckAll never sees it and the history-gate system property is missing. See Important constraints.

4. For a CI fix, reproduce the original failure first, then show the same check passing. A render task in particular goes UP-TO-DATE off a stale .error.json sidecar — verify a render fix with --rerun, never a plain re-invocation.