review-correctness

The correctness check

The correctness check is the standing review of whether a change is correct and safe as merged. It is the concern, not a tool: no reviewer is presumed.

The review formula is the frame you work in. It pins the commit, makes the review workspace and the hb keepalive, and carries the verdict envelope and the one signoff.sh call. This file is what the correctness check reads, runs and judges inside that frame. Run each block below in a shell that has first run the formula's pin, keepalive and workspace blocks, so the pins, REVIEW_WT and hb are set.

Read the whole diff

Read the whole diff the formula pins, origin/$BASE...$REVIEWED_OID. A large diff gets read in chunks, not sampled.

Settle the test evidence

The self-review that built a commit runs the rig's declared test command and stamps the head it saw pass on the work bead as self_review_passed_sha. The anchor's stamp is evidence only when it is the reviewed commit's full sha and the rig declares a test command. A merge of the base or a rework round leaves it naming an older head, and where the rig declares no test command the stamp certifies no declared tests:

# >>> review-test-evidence
ANCHOR=$(printf '%s' "$M" | jq -r '.anchor_bead // empty')
STAMP=""
[ -n "$ANCHOR" ] && STAMP=$(gc bd show "$ANCHOR" --json 2>/dev/null | jq -r '.[0].metadata.self_review_passed_sha // empty' 2>/dev/null)
DECLARED=$(gc formula show mol-polecat-work ${GC_RIG:+--rig="$GC_RIG"} --json 2>/dev/null | jq -r '[.vars[]? | select(.name == "affected_tests_command" or .name == "test_command") | if .rig_default != null then .rig_default else (.default // "") end | select(. != "")] | length' 2>/dev/null)
if [ -n "$STAMP" ] && [ "$STAMP" = "$REVIEWED_OID" ] && [ "${DECLARED:-0}" -gt 0 ] 2>/dev/null; then
  echo "test evidence: the anchor's self-review passed the rig's declared tests at $REVIEWED_OID; run no suite"
else
  echo "no test evidence at ${REVIEWED_OID:-an unpinned commit} (anchor stamp: ${STAMP:-none}; declared test commands: ${DECLARED:-unread}); run the suites the diff touches"
fi
# <<< review-test-evidence