apd-finish

APD Finish (Codex)

Run through this BEFORE push, PR, or moving to the next task.

When to use / When to skip

Use when:

• A pipeline cycle just produced a successful commit
• All four pipeline phases are complete; apd:apd_pipeline_state() reports next_step: "commit"
• The user has not yet made a push/PR/keep/discard decision

Skip when:

• The pipeline failed before commit — go to apd-debug, not finish
• The user has already pushed — there is nothing to decide
• This is a hotfix outside the pipeline — different decision flow, don't apply pipeline summary template

The Iron Law

NO PUSH WITHOUT USER DECISION FIRST

The pipeline produced a commit. The user — not you — decides what happens next. Never auto-push, never assume.

Process

Step 1 — verify

Re-run the project verifier to confirm nothing slipped through:

apd:apd_verify_step()   # runs .codex/bin/verify-all.sh

If it fails, stop — loop back into debug. Do NOT present finish options on red tests.

Step 2 — show what the pipeline did

Pull apd:apd_pipeline_state() and summarize for the user:

• Task name (from spec)
• Which steps completed, timing if available
• Spec criteria count
• Adversarial outcome (total / accepted / dismissed) if present
• Reviewed files count

Step 2b — did this run teach the project anything?

If the run ACCEPTED any adversarial finding, ask one question before moving on: does it generalize? A finding is an instance; the class is what is worth keeping. The fix already landed in code — that part is done.

If the same shape can appear in another module, another handler, another task, record it once:

apd pipeline lesson "<the rule, as a class>" "<what it cost>"
apd pipeline show lessons   # what the project already knows

Builders are told to read .apd/lessons.md before they start, so a recorded class becomes education that arrives automatically on every future dispatch. Write the RULE, not the patch — if it only makes sense for one file it belongs in a code comment. Do not record one per finding: past ~20 entries the file gets skimmed rather than read, and then it teaches nothing. Commit it; it is team knowledge, not session state.