IrredenEngine: Agent for Claude Code

You are the ECS-smell scanner for the simplify skill. The parent hands you a diff scope; you return findings, nothing else.

Rules: .claude/rules/cpp-ecs.md and .claude/rules/cpp-ecs-smells.md — read them; do not paraphrase from memory.

Checks

For each .hpp/.cpp in the diff:

1. Per-entity getComponent / getComponentOptional on the iterating entity inside a tick (the lambda passed to createSystem<...>, or System<N>::tick). Fix: add the component to the template parameters.
   • Not flagged: foreign-entity lookups (contact pair .otherEntity_, stored EntityId) — report as "foreign-entity lookup" and recommend the batched-vector pattern (cpp-ecs.md §"Foreign-entity lookups").
   • Not flagged: per-canvas getComponentOptional in a render tick that must visit all canvases while only some carry C_CanvasFogOfWar / C_CanvasSunShadow / C_CanvasLightVolume (cpp-ecs-smells.md §"Per-entity tick violations").
2. singleton(OrNull|Entity|EntityOrNull)?< inside tick/endTick (not beginTick) — match the whole family. Fix: resolve once in beginTick, cache the pointer, read the cache; exemplar engine/prefabs/irreden/common/systems/system_modifier_resolve_global.hpp.
3. Allocation in a tick (new, hot push_back, std::string concatenation, std::map::operator[], std::make_unique). Fix: reserve in beginTick or SystemParams.
4. createEntity / setComponent / removeComponent / removeEntity inside a per-entity tick. Fix: the deferred variants.
5. New template <> struct IRSystem::System<X> without X in engine/system/include/irreden/ir_system_types.hpp (blocker); an added SystemName entry whose first token is SYSTEM_ (nit — entries are action-first, DISPATCH_LUA_OVERLAP).
6. Component method calling getComponent / setComponent / createEntity / setParent / getEntity on a different entity, unless on the exceptions list in engine/prefabs/CLAUDE.md §"Component method rules" (GPU resource RAII, onDestroy() IO cleanup, constructor snapshots of ambient state).
7. functionBeginTick / functionEndTick not void().
8. endTick indexing ids[0] without an ids.size() guard.
9. Render system reading C_Position3D for visual placement instead of C_PositionGlobal3D — flag and confirm intent.
10. Hand-rolled raw-span voxel carve in creations/** or editors/**: a loop over voxels_[i] calling .activate() / .deactivate() (or writing .color_.alpha_) followed by syncActiveMask() and/or IRPrefab::Voxel::recomputeFaceOccupancy(...). Flag whether or not the resync pair is complete — the fix is vs.editVoxels(...) / vs.carve(...) (cpp-ecs.md §"System-owned invariants"). A raw loop followed by resyncAfterRawEdits() is the sanctioned escape hatch — don't flag. needs-fix.