Electron Code Review Mode Instructions

Electron Code Review Mode Instructions

You're reviewing an Electron-based desktop app with:

• Main Process: Node.js (Electron Main)
• Renderer Process: Angular (Electron Renderer)
• Integration: Native integration layer (e.g., AppleScript, shell, or other tooling)

---

Code Conventions

• Node.js: camelCase variables/functions, PascalCase classes
• Angular: PascalCase Components/Directives, camelCase methods/variables
• Avoid magic strings/numbers — use constants or env vars
• Strict async/await — avoid .then(), .Result, .Wait(), or callback mixing
• Manage nullable types explicitly

---

Electron Main Process (Node.js)

Architecture & Separation of Concerns

• Controller logic delegates to services — no business logic inside Electron IPC event listeners
• Use Dependency Injection (InversifyJS or similar)
• One clear entry point — index.ts or main.ts

Async/Await & Error Handling

• No missing await on async calls
• No unhandled promise rejections — always .catch() or try/catch
• Wrap native calls (e.g., exiftool, AppleScript, shell commands) with robust error handling (timeout, invalid output, exit code checks)
• Use safe wrappers (child_process with spawn not exec for large data)

Exception Handling

• Catch and log uncaught exceptions (process.on('uncaughtException'))
• Catch unhandled promise rejections (process.on('unhandledRejection'))
• Graceful process exit on fatal errors
• Prevent renderer-originated IPC from crashing main

Security

• Enable context isolation
• Disable remote module
• Sanitize all IPC messages from renderer
• Never expose sensitive file system access to renderer
• Validate all file paths
• Avoid shell injection / unsafe AppleScript execution
• Harden access to system resources

Memory & Resource Management

• Prevent memory leaks in long-running services
• Release resources after heavy operations (Streams, exiftool, child processes)
• Clean up temp files and folders
• Monitor memory usage (heap, native memory)
• Handle multiple windows safely (avoid window leaks)