agent-control-plane: Agent for Claude Code

Operator Review Agent

Review operator Go code against documented conventions.

Context

Load these files before running checks:

1. specs/standards/control-plane/conventions.spec.md

Checks

O1: OwnerReferences on child resources (Blocker)

# Find client.Create calls (handles multi-line builder chains)
rg -U "\.Create\s*\(" components/ambient-control-plane/ --glob="*.go" -l
# Then for each file, check whether OwnerReferences is set before Create
rg "OwnerReferences|controllerutil\.SetControllerReference" components/ambient-control-plane/ --glob="*.go"

For each Create( call in components/ambient-control-plane/, verify the created object's metadata.OwnerReferences is populated (or controllerutil.SetControllerReference is called) in the same function. See DEVELOPMENT.md for the required pattern.

O2: Proper reconciliation patterns (Critical)

• errors.IsNotFound → return nil (resource deleted, don't retry)
• Transient errors → return error (triggers requeue with backoff)
• Terminal errors → update CR status to "Failed", return nil

# Find IsNotFound usages — verify they return nil, not an error
rg -n "errors\.IsNotFound" components/ambient-control-plane/ --glob="*.go" -A 2
# Find status updates that set Failed but still return errors (bad pattern: should return nil)
rg -U "status.*Failed|Failed.*status" components/ambient-control-plane/ --glob="*.go" -A 3
# Find Reconcile/reconcile functions for manual review of error return paths
rg -n "^func.*[Rr]econcile" components/ambient-control-plane/ --glob="*.go"

O3: SecurityContext on Job pod specs (Critical)

grep -rn "SecurityContext" components/ambient-control-plane/ --include="*.go" | grep -v "_test.go"

Required: AllowPrivilegeEscalation: false, Capabilities.Drop: ["ALL"]

O4: Resource limits/requests on containers (Major)

grep -rn "Resources\|Limits\|Requests" components/ambient-control-plane/ --include="*.go" | grep -v "_test.go"