gpui-review

GPUI Code Review

Perform comprehensive code review of GPUI applications, identifying issues with patterns, performance, state management, and suggesting improvements.

Arguments

• $1: Path (optional) - Specific file or directory to review. If not provided, reviews entire project.

Workflow

1. Search for GPUI Code

• Locate all .rs files in the project or specified path
• Identify files using GPUI (imports gpui::* or specific GPUI types)
• Categorize files by type:
  • View components (impl Render)
  • Models (application state)
  • Main entry points
  • Utility code

2. Analyze Component Patterns

Review each component for:

Component Structure

• Proper use of View vs Model types
• Clear separation of concerns
• Component has single responsibility
• Props/dependencies passed explicitly
• Proper lifetime management

Anti-patterns

• God components (doing too much)
• Tight coupling between components
• Improper state ownership
• Missing error handling
• Inconsistent naming conventions

Example issues to flag:

// BAD: Component doing too much
impl Render for GodComponent {
    fn render(&mut self, cx: &mut ViewContext<Self>) -> impl IntoElement {
        // Fetching data
        // Computing business logic
        // Rendering UI
        // Handling all events
        // Managing multiple concerns
    }
}

// GOOD: Focused component
impl Render for FocusedComponent {
    fn render(&mut self, cx: &mut ViewContext<Self>) -> impl IntoElement {
        let state = self.model.read(cx);
        div().child(format!("Count: {}", state.count))
    }
}

3. Check State Management

Review state management for:

Model Usage

• State properly encapsulated in Model types
• Appropriate use of cx.new_model()
• State updates use model.update()
• No direct state mutation outside updates
• Proper state ownership hierarchy

Subscription Management

• Subscriptions created during initialization, not render
• Subscriptions stored to prevent cleanup
• cx.observe() used for model changes
• No subscription leaks
• Proper cleanup in Drop if needed