tokio-review

Tokio Review Command

This command performs comprehensive code review of Tokio-based applications, identifying async/await anti-patterns, performance issues, blocking operations, and suggesting improvements.

Arguments

• $1 - File path or directory to review (optional, defaults to current directory)

Usage

/rust-tokio-expert:tokio-review
/rust-tokio-expert:tokio-review src/handlers/
/rust-tokio-expert:tokio-review src/main.rs

Workflow

1. Analyze Target

   • If no argument provided, scan current directory for Rust files
   • If directory provided, scan all .rs files recursively
   • If file provided, review that specific file

2. Read Relevant Files

   • Use Glob tool to find Rust source files
   • Read all identified files using Read tool
   • Prioritize files in: src/main.rs, src/lib.rs, src/**/*.rs

3. Invoke Agent

   • Use Task tool with subagent_type="rust-tokio-expert:tokio-performance"
   • Provide all source code context to the agent
   • Request comprehensive analysis

4. Review Checklist

   The agent should analyze for:

   Async/Await Anti-Patterns

   • Blocking Operations in Async Context

     • Detect std::thread::sleep instead of tokio::time::sleep
     • Identify blocking I/O operations
     • Find CPU-intensive operations not wrapped in spawn_blocking

   • Holding Locks Across Await Points

     • Detect std::sync::Mutex or tokio::sync::Mutex held across .await
     • Suggest lock scope reduction
     • Recommend alternatives like channels

   • Unnecessary Cloning

     • Identify expensive clones in async contexts
     • Suggest Arc for shared data
     • Recommend reference passing where possible

   • Futures Not Being Awaited

     • Find async functions called without .await
     • Detect unused futures
     • Identify missing error handling

   Performance Issues

   • Excessive Task Spawning
     • Detect unbounded task creation in loops
     • Suggest buffer_unordered or bounded concurrency
     • Recommend semaphore-based limiting