review

Review PR #$ARGUMENTS

Multi-faceted code review with parallel analysis. Follows Explore > Plan > Code > Verify loop.

Required Skills

• llm-operator-principles — operator stance (inlined above): convergence is zero findings, fix in this PR, no calendar-time estimates, escalate only for true decisions
• code-review-methodology — 6-facet review, finding synthesis, adversarial protocol
• holdout-validation — cross-reference self-review claims against file state (Phase 3)
• run-state-management — FlowRun/FlowActivity records at phase boundaries (v3 runtime)

# Inline the Required Skills above so their rules are in context before the
# first phase runs (commands cannot preload skills from frontmatter). Ambient
# skills load whole; dispatched skills (context: fork / agent:) load their
# `## Contract` section and run in full when this command invokes
# Skill(<name>). Output per `references/command-output-format.md`.
"$(__fr="${CLAUDE_PLUGIN_ROOT:-}";[ -x "$__fr/bin/cascade-resolve.sh" ]||__fr=$({ echo plugins/flow;ls -d "$HOME"/.claude/plugins/cache/synapti-marketplace/flow/*/ 2>/dev/null|sort -Vr;echo "$HOME/.claude/plugins/marketplaces/synapti-marketplace/plugins/flow"; }|while read -r __p;do [ -x "${__p%/}/bin/cascade-resolve.sh" ]&&{ echo "${__p%/}";break;};done);echo "$__fr")/bin/flow-load-skills.sh" llm-operator-principles code-review-methodology holdout-validation run-state-management

true

Phase 1: EXPLORE

gh pr checkout stays inline below (mutating working tree); read-only context-gathering is in the ! block.

# Take the first whitespace-separated token; accept only if it is all digits.
# A non-numeric token (e.g., "foo42" or "evil;rm") is rejected with empty
# PR_NUM so it never reaches the prompt context or any downstream shell.
#
# Output: `###`-headed sections + KEY=value per
# `references/command-output-format.md`. STATE=blocked on bad input.
_RAW="$ARGUMENTS"  # Claude Code substitutes the bare arg token, not bash parameter-expansion
ARG1="${_RAW%% *}"
case "$ARG1" in
  ''|*[!0-9]*) PR_NUM="" ;;
  *) PR_NUM="$ARG1" ;;
esac

echo "### PR Reference"
if [ -z "$PR_NUM" ]; then
  echo "STATE=blocked"
  echo "ERROR=PR number required (all-digit). Usage: /flow:review <pr-number>"
else
  echo "STATE=ok"
  echo "PR_NUM=$PR_NUM"

  # Section: PR Details
  echo ""
  echo "### PR Details"
  gh pr view "$PR_NUM" --json title,headRefName,baseRefName,changedFiles,additions,deletions,labels,author,reviews --jq '"TITLE=\"\(.title)\"\nHEAD_BRANCH=\(.headRefName)\nBASE_BRANCH=\(.baseRefName)\nAUTHOR=@\(.author.login)\nCHANGED_FILES=\(.changedFiles)\nADDITIONS=\(.additions)\nDELETIONS=\(.deletions)\nLABELS=\([.labels[].name] | join(","))\nREVIEW_COUNT=\(.reviews | length)"' 2>/dev/null

  # Section: Linked Issue (parsed from PR body)
  echo ""
  echo "### Linked Issue"
  LINKED=$(gh pr view "$PR_NUM" --json body --jq '.body' 2>/dev/null | grep -oE '#[0-9]+' | head -1 | tr -d '#')
  echo "LINKED_ISSUE=${LINKED:-none}"

  # Section: Previous Reviews (follow-up detection)
  echo ""
  echo "### Previous Reviews"
  # Capture gh exit separately. Without this, `jq 'length' | echo "0"` on a
  # failed gh call (auth, network) produces no output (jq 1.8 empty-input
  # ⇒ exit 0) so `||` doesn't fire, COUNT stays empty, and the section
  # silently leaks `REVIEW_COUNT=` (bare empty).
  PREV_JSON=$(gh pr view "$PR_NUM" --json reviews --jq '.reviews' 2>/dev/null); GH_EXIT=$?
  if [ $GH_EXIT -ne 0 ]; then
    echo "REVIEW_COUNT=0"
    echo "STATE=unavailable"
  else
    PREV_COUNT=$(echo "$PREV_JSON" | jq 'length' 2>/dev/null)
    [ -z "$PREV_COUNT" ] && PREV_COUNT=0
    echo "REVIEW_COUNT=$PREV_COUNT"
    if [ "$PREV_COUNT" = "0" ]; then
      echo "STATE=empty"
    else
      echo "$PREV_JSON" | jq -r '.[] | "REVIEW=state=\(.state) by=@\(.author.login) at=\(.submittedAt)"' 2>/dev/null
    fi
  fi

  # Section: Diff Files
  echo ""
  echo "### Diff Files"
  DIFF_FILES=$(gh pr diff "$PR_NUM" --name-only 2>/dev/null)
  # `grep -c '.' || echo 0` produces multi-line `0\n0` on empty input — use
  # explicit empty-check.
  if [ -z "$DIFF_FILES" ]; then
    DIFF_FILE_COUNT=0
  else
    DIFF_FILE_COUNT=$(printf '%s\n' "$DIFF_FILES" | wc -l | tr -d ' ')
  fi
  echo "DIFF_FILE_COUNT=$DIFF_FILE_COUNT"
  if [ "$DIFF_FILE_COUNT" = "0" ]; then
    echo "STATE=empty"
  else
    printf '%s\n' "$DIFF_FILES" | sed 's/^/DIFF_FILE=/'
  fi
fi

true