typescript-google-style-review

Google style review

Review checks derived from the Google Style Guide. Points this project decides for itself, rather than taking from the guide, are marked (project).

Review the files in the change under review. New files follow the rules completely; in an existing file, new code follows the file's conventions where the rules are silent but never violates a rule. Do not demand cleanups of unchanged code. Flag style-only churn mixed into a functional change; style-only edits go in their own change.

Gate on the toolchain first

Confirm npx tsc --noEmit and npx eslint . --max-warnings=0 pass. A failure of either is itself a finding; do not hand-review what the tools report. The toolchain gates: compilation, indentation, quotes, semicolons, trailing commas, brace placement and spacing, case indentation, line length, mandatory braces on control-flow bodies, === with the == null exception, dot notation, declare-before-use, unused variables, namespace, require(), @ts-ignore, and bare any. Do not open findings for these when the gate is green.

Where a rule overlaps the linter, review the part the linter cannot judge: every eslint-disable directive names one rule, carries a -- <reason>, and the reason holds for that line.

Quick scan

Grep the changed files for these tokens; every hit needs a stated justification or becomes a finding:

var · export default outside the extension entry point · export let · public · # private fields · const enum · debugger · with · eval / new Function · new String / new Number / new Boolean / new Object / new Array / Array( · parseInt / parseFloat · @ts-ignore / @ts-nocheck · @ts-expect-error outside a unit test · arguments · .bind( · <Type>value assertions · Object.defineProperty · prototype or global modification.

Formatting the linter does not check

• Bodies do not begin or end with a blank line; one blank line separates methods and the constructor; blank lines inside a body only group statements.
• Multi-line comments are consecutive // lines, not /* */ blocks; no boxes around comments.
• Strings use the special escapes (\n, \t, \'), not numeric ones; a printable non-ASCII character appears as itself ('μs'); only non-printables are escaped, with a comment; the only whitespace character is the ASCII space.
• No space after ...; the star is attached in function* and yield*.
• No semicolon after a class declaration or method body; a statement containing a class expression keeps its semicolon.