mpga-simplify

simplify

Simplify code using Kent Beck's 4 Rules of Simple Design and Sandi Metz rules.

Trigger: User wants to improve code elegance, reduce complexity, or simplify code. Also triggered by: "simplify this", "too complex", "clean this up", "reduce complexity", "make this simpler".

Protocol

1. Read target code — we need to see the MESS before we drain it:

   • If user specifies files, use those
   • If git diff has changes, examine the changed files
   • If no target specified, use the current scope's implementation files

2. Apply Kent Beck's 4 Rules of Simple Design (in priority order — and the order MATTERS, folks, tremendous priority order):

   • Passes all tests — NON-NEGOTIABLE. The code must remain correct after every change.
   • Reveals intention — does the code clearly communicate what it does? If you can't read it and know what it does IMMEDIATELY, it's a DISASTER.
     • Look for: unclear variable names, magic numbers, opaque boolean params
     • Suggest: rename to reveal intent, extract explanatory variables, use named constants
   • No duplication — DRY, but not at the cost of clarity.
     • Look for: copy-pasted logic, similar functions that differ by one param, repeated conditionals
     • Suggest: extract shared functions, use polymorphism, apply template method pattern
   • Fewest elements — remove anything that doesn't serve the above three. If it doesn't EARN its place in the codebase, it's OUT. Less is MORE!
     • Look for: unnecessary abstractions, premature generalization, dead code, unused imports
     • Suggest: inline trivial wrappers, collapse unnecessary class hierarchies, delete dead code

3. Apply Sandi Metz Rules for method/class size — these are the RULES OF DISCIPLINE, folks, and we LOVE discipline:

   • Classes should be no longer than 100 lines.
   • Methods should be no longer than 5 lines — FIVE. That's it. Short, powerful, BEAUTIFUL. Less is MORE.
   • Pass no more than 4 parameters to a method — four is PLENTY. If you need more, your design is a DISASTER.
   • Controllers should instantiate only one object — ONE. We're keeping it SIMPLE, people.
   • Flag violations with specific file:line references and severity