test-review

A reusable review guide for evaluating DataHub smoke tests and integration tests against established standards.

In plain words
What is it for?
It helps inspect tests, compare them with standards, use review scripts and templates, and report quality issues.
Why use it?
It explains the review checklist and provides fallback steps when agent-specific features, such as parallel sub-agents, are unavailable.

Skill for Claude CodeCodex

Install

Getting it into your agent

One page per mod, every tool's command on it. A separate URL per tool would split the same page into five that compete with each other.

agentmods
npx agentmods add skills/datahub-project/datahub/test-review
Any agent
npx skills add datahub-project/datahub --skill test-review
Clone the repo
git clone --depth 1 https://github.com/datahub-project/datahub

Made for: Claude Code, Codex.

Per session 0 Skills are progressive disclosure: only the name and description are preloaded; the body loads when the skill is used.
When invoked 2,473 The whole file, excluding the scripts and references it only reads on demand.
Security scan A 0 findings. Scan, not verified.
Origin original No closer match found in the catalogue.
Token cost

What it costs to keep this loaded

Counted locally with the o200k_base tokenizer, which is exact for GPT models; Claude uses its own tokenizer and its counts differ. Treat this as one consistent yardstick across the catalogue rather than a bill. Prices are per million input tokens.

ModelPer sessionOnce invoked
Fable 5 $0.00000 $0.02473
Opus 5 $0.00000 $0.01236
Sonnet 5 $0.00000 $0.00495
Haiku 4.5 $0.00000 $0.00247

Measured yesterday against content hash a211e30ecca4, method: parsed. Prices are Anthropic first-party input rates as of 2026-08-30, from the pricing page.

Security

Grade A, and why

test-review scanned grade A with 0 findings against 26 rules in 11 categories — prompt injection, anti-refusal, data exfiltration, privilege escalation, supply chain, agent snooping, system-prompt leakage, SSRF and excessive agency — measured yesterday.

The scan reads SKILL.md. This mod also ships 1 executable file (scripts/detect-test-changes.sh), listed below but not scanned — reading those needs a real analyzer, not pattern matching.

A static scan of the body, not an audit. Every finding is printed with the line that produced it so you can judge whether it matters here. A mod is markdown that instructs an agent; that is exactly why what it instructs is worth reading.

Nothing flagged

None of the 26 patterns this scan looks for appear in this file: no shell pipes, no recursive deletes, no credential paths, no hidden text, no instruction-override or anti-refusal phrasing, no agent-config snooping. That is not a guarantee, it is the absence of the things that are checkable.

.agent-skills/test-review/SKILL.md · 302 lines

How it starts

The opening of the file, as written. The whole thing — 302 lines — stays where its author put it; the contents beside it link to each section on GitHub.

DataHub Test Review

You are an expert DataHub test reviewer. Your role is to evaluate smoke tests and integration tests against established testing standards, identify issues, and provide actionable feedback.


Multi-Agent Compatibility

This skill is designed to work across multiple coding agents (Claude Code, Cursor, Codex, Copilot, Gemini CLI, Windsurf, and others).

What works everywhere:

  • All review checklists, standards references, and procedures in this document
  • Bash for running scripts (detect-test-changes.sh, gh CLI, git diff)
  • Reading files, searching code, and generating review reports

Claude Code-specific features (other agents can safely ignore these):

  • The /test-review slash command (.claude/commands/test-review.md) loads this skill automatically
  • The test-quality-analyzer agent (.claude/agents/test-quality-analyzer.md) can be dispatched for parallel analysis -- fallback instructions are provided inline for agents that cannot dispatch sub-agents
  • TaskCreate/TaskUpdate for progress tracking -- if unavailable, simply proceed through the steps sequentially

Standards file paths: All standards are in the standards/ directory alongside this file. All paths below are relative to .agent-skills/test-review/.


Quick Start

Full review? -> Load standards, gather test files, then launch test-quality-analyzer agent (or perform checks directly)

PR review? -> Detect changed test files, classify them, then analyze only changed files


Scope

In Scope

  • smoke-test/ -- Python pytest smoke tests (API-level tests against a running DataHub instance)
  • smoke-test/tests/cypress/ -- Cypress integration tests (UI/browser-based tests) and their Python launcher (integration_test.py)
  • smoke-test/tests/ -- shared test utilities, fixtures, and helpers

Out of Scope

  • metadata-ingestion/tests/integration/ -- ingestion connector tests (covered by datahub-connector-pr-review)
  • metadata-ingestion/tests/unit/ -- unit tests
  • metadata-ingestion/src/datahub/testing/ -- ingestion testing utilities (covered by connector review)

Read the full file on GitHub · 302 lines

Files

What ships with it

6 files beside SKILL.md in the same directory: the scripts, references and assets a skill reads on demand. Not counted in the per-session cost; read them before you install if any of them is executable.

Changes

What this file has done since we first saw it

Hashed on every crawl. A supply-chain change to an agent config is a question of when, not whether, so the history is kept rather than the latest state alone.

  1. yesterday First seen · 302 lines · 0 tokens per session scan A a211e30ecca4

Subscribe to this mod's changes

test-review is a skill published in the GitHub repository datahub-project/datahub (12,618 stars, last pushed yesterday), licensed Apache-2.0. It costs nothing until one of its globs matches a file; then it loads 2,473 tokens. A static security scan graded it A with 0 findings. No closer match exists in the catalogue, so it is treated as the original; first seen 2026-08-30.

Related

Other skills, from other repositories

marmot

Interact with a Marmot data catalog instance. Use this skill when the user wants to search for data assets, view lineage, browse glossary terms, check pipeline runs, manage tags or owners, view metrics, or do anything related to their data catalog. Covers the Marmot CLI, REST API and MCP server.

marmotdata/marmot · 66 tokens

connector-review

Review an OpenMetadata connector against golden standards. Runs multi-agent analysis covering architecture, code quality, type safety, testing, and performance. When a PR number is given, automatically posts the quality summary to the PR description and a detailed review as a PR comment.

open-metadata/OpenMetadata · 55 tokens

scaffold-connector

Build a new OpenMetadata connector from scratch — scaffold JSON Schema, Python boilerplate, and AI context using schema-first architecture with code generation across Python, Java, TypeScript, and auto-rendered UI forms.

open-metadata/OpenMetadata · 47 tokens

test-enforcement

Use after implementing any feature or fix to ensure comprehensive test coverage. Enforces 90% line coverage in openmetadata-service, integration tests for all API endpoints in openmetadata-integration-tests, and Playwright E2E tests for UI changes.

open-metadata/OpenMetadata · 53 tokens

connector-audit

Deep reliability audit for OpenMetadata connectors — runs 7 investigation prompts (metadata, errors, auth, lineage, scale, synthesis, implementation) against connector standards.

open-metadata/OpenMetadata · 35 tokens

playwright-validation

Use when validating UI changes in a branch require Playwright E2E testing. Reviews branch changes, validates UI with Playwright MCP, and adds missing test cases.

open-metadata/OpenMetadata · 37 tokens