code-review-incorporate

Code Review Incorporate

Incorporate findings from a code review doc into the implementation. Make the code changes, commit with structured trailers linking back to the review, and update the review doc's disposition table.

Inputs

• $0: Path to the review doc (e.g., docs/reviews/edb-d6kq.3-r1-review-reviewer-1.md)

Phase 1: Read & Understand

1. Read the review doc at $0
2. Extract: bead ID, commit range reviewed, plan doc path, reviewer name, findings list
3. Read the plan doc (if referenced) to understand original intent
4. Read the code files referenced in each finding
5. Check for existing disposition tables in the review doc (from prior incorporate rounds on the same review)

Phase 2: Evaluate Each Finding

For every finding in the review doc:

1. Read the referenced code and understand the issue
2. Decide disposition:
   • Incorporate: The finding is valid — plan the code fix
   • Not Incorporate: The finding is invalid or the current code is intentional — prepare rationale
   • Deferred: Valid but out of scope — create a follow-up bead

Disposition Criteria

Valid reasons for "Not Incorporate":

• The current code is intentional and the reviewer misunderstands the design
• The change would introduce import cycles or architectural violations
• The finding conflicts with a decision documented in the plan doc
• The reviewer's suggested fix has correctness issues of its own

Invalid reasons for "Not Incorporate":

• "Too much work" (effort is not a factor)
• "Works fine as-is" (if there's a real quality issue, fix it)

Phase 3: Discussion with Reviewer

Do not apply changes yet. Reach consensus with the reviewer first.

Step 1: Send Proposed Dispositions

Send a single h2 send message to the reviewer with proposed dispositions:

Proposed dispositions for {review-doc-path}:

1. P0 - {title}: Incorporate — {brief description of planned fix}
2. P1 - {title}: Not Incorporate — {rationale}
3. P2 - {title}: Incorporate — {brief description}
...

Please confirm, or push back on any you disagree with.