validate-conventions

Validate Conventions

Review changed code against all project conventions defined in CONVENTIONS.md.

Steps

1. Get Changed Files

Run git diff --name-only HEAD to find modified files. If no uncommitted changes, check git diff --name-only HEAD~1 for the last commit.

If the user specifies particular files, use those instead.

2. Read Changed Files

Read each changed file to inspect the code.

3. Check Against Rules

For each file, check ALL of the following rules:

Import Rules

• StyleSheet imported from react-native-unistyles, NOT react-native
• Text imported from @/common/components/Text, NOT react-native
• z imported from zod/v4, NOT zod
• Path aliases used (@/ or ~/), no deep relative imports (../../..)
• Import order: React core > third-party > @/ internal > relative
• Type imports use import type { ... }
• Imports from barrel files, not implementation files (e.g., @/common/components/Button not @/common/components/Button/Button)

Component Rules

• Named exports in src/ files
• Default exports in app/ screen files
• styles.useVariants() called before accessing styles (if using variants)
• No inline styles - all styles in StyleSheet.create
• Accessibility props on all interactive elements:
  • accessibilityRole on Pressable, TouchableOpacity, buttons
  • accessibilityLabel on interactive elements
  • accessibilityState for disabled/busy/selected states

Style Rules

• StyleSheet.create((theme) => ({...})) pattern with theme callback
• No color literals (#hex, rgb(), named colors) - use theme.colors.*
• No hardcoded numeric spacing - use theme.metrics.spacing.* or theme.metrics.spacingV.*
• No hardcoded font sizes - use theme.fonts.size.*
• No hardcoded border radius - use theme.metrics.borderRadius.*

State Management Rules

• Zustand stores accessed with selectors: useStore((s) => s.field), NOT useStore()
• No useAuthStore() without selector
• No useAuthStore.getState() inside React components (only in non-React code)
• Server state via React Query, NOT local state + useEffect for API data