uw-code-review

Code Review

Pre-commit quality gate. Read the target files, then run this checklist. Output one structured report per review. Fix all issues before committing.

Before You Start

1. Read docs/CODING_STANDARDS.md for formatting, class structure, serialization, null safety, and async rules.
2. Read docs/NAMING_CONVENTIONS.md for naming rules (private fields, properties, files, asmdefs).
3. Read docs/GDD.md for Gherkin scenarios — every scenario should have a corresponding test.
4. Read the files being reviewed in full before assessing.

Checklist

1. Rules Compliance

• All Inspector fields use [SerializeField] private — no public fields on MonoBehaviours
• All component references cached in Awake() or Start() — never in Update/FixedUpdate/LateUpdate
• GameDebug used instead of Debug.Log / Debug.LogError / Debug.LogWarning
• New Input System only — no Input.GetKey* / Input.GetAxis*
• TryGetComponent<T>() preferred over GetComponent<T>() where component may be absent
• No Unity API calls from background threads
• No .meta file modifications

2. Naming Conventions

• Private fields: _camelCase
• Public properties & methods: PascalCase
• Parameters & local variables: camelCase
• Booleans: is/has/can/should prefix (e.g. _isGrounded, CanJump)
• Events: On prefix (e.g. OnDeath)
• Static fields: s_camelCase
• Class name matches file name

3. Code Quality

• No magic numbers or hardcoded strings — use constants, ScriptableObjects, or serialized fields
• No FindObjectOfType<T>() or GameObject.Find() (except in editor-only code)
• No cross-assembly references that violate the TDD's asmdef dependency graph
• K&R braces (opening brace on same line)
• 4-space indentation (no tabs)

4. Performance

• No new allocations inside Update/FixedUpdate/LateUpdate (no GC pressure in hot paths)
• Particles are pooled or have Stop Action set to Destroy with pool backing
• DOTween/PrimeTween tweens are killed in OnDestroy or OnDisable
• No string concatenation in hot paths — use GameDebug with conditional compilation