architecture-review

Architecture Review

Architecture and design pattern validation for ultrawork planning and verification phases.

What This Skill Provides

Structured approach to evaluating:

• Component boundaries and separation of concerns
• Modularity and coupling
• Design patterns and architectural principles
• Scalability and maintainability
• API design and interfaces

When to Use This Skill

During PLANNING phase:

• Reviewing planner's task decomposition
• Validating design documents
• Assessing technical approach
• Identifying architectural risks

During VERIFICATION phase:

• Ensuring implementation matches design
• Checking component boundaries
• Validating separation of concerns
• Reviewing integration points

Core Principles

1. Separation of Concerns (SoC)

Checklist:

[ ] Business logic separated from presentation
[ ] Data access layer isolated
[ ] Authentication/authorization in dedicated modules
[ ] Configuration separate from code
[ ] API routes separate from business logic
[ ] Validation logic reusable across layers
[ ] Error handling centralized
[ ] Logging abstracted

Red Flags:

• Business logic in React components
• Database queries in route handlers
• Authentication mixed with business logic
• Configuration hardcoded in multiple files

Examples:

// ❌ Bad: Mixed concerns
app.post('/api/users', async (req, res) => {
  // Authentication + validation + business logic + DB access in one place
  if (!req.headers.authorization) return res.status(401).json({ error: 'Unauthorized' });
  if (!req.body.email) return res.status(400).json({ error: 'Email required' });
  const user = await db.users.create(req.body);
  res.json(user);
});

// ✅ Good: Separated concerns
app.post('/api/users',
  authenticate,           // Auth middleware
  validateCreateUser,     // Validation middleware
  createUserHandler       // Route handler delegates to service
);

async function createUserHandler(req, res) {
  const user = await userService.createUser(req.body); // Business logic in service
  res.json(user);
}