code-quality-review

Code Quality Review

Systematic code quality assessment for ultrawork verification phase.

What This Skill Provides

Structured checklists for evaluating code quality across multiple dimensions:

• Logic and readability
• Error handling and resilience
• Code style and maintainability
• Performance and efficiency

When to Use This Skill

• During VERIFICATION phase after workers complete tasks
• When reviewing evidence before marking tasks as complete
• Before approving design decisions that impact code quality
• When auditing implementations for production readiness

Quality Dimensions

1. Logic and Readability

Checklist:

[ ] Functions have single, clear responsibilities
[ ] Functions are under 50 lines
[ ] Files are under 800 lines
[ ] Nesting depth is 4 levels or less
[ ] Control flow is straightforward (no convoluted conditionals)
[ ] Variable and function names are descriptive
[ ] No magic numbers (constants are named)
[ ] Complex logic has explanatory comments
[ ] Boolean conditions are readable (avoid double negatives)
[ ] Early returns reduce nesting

Red Flags:

• Functions doing multiple unrelated things
• Variable names like x, tmp, data, thing
• Magic numbers: if (status === 42)
• Deep nesting: if { if { if { if { ... }}}}
• Complex conditions: if (!(!isValid && !isExpired))

Examples:

// ❌ Bad: Unclear logic, magic numbers
function process(x) {
  if (x > 100 && x < 500) {
    return x * 0.95;
  }
  return x;
}

// ✅ Good: Clear intent, named constants
const BULK_ORDER_MIN = 100;
const BULK_ORDER_MAX = 500;
const BULK_DISCOUNT_RATE = 0.95;

function applyBulkDiscount(orderTotal) {
  const isBulkOrder = orderTotal >= BULK_ORDER_MIN && orderTotal <= BULK_ORDER_MAX;
  return isBulkOrder ? orderTotal * BULK_DISCOUNT_RATE : orderTotal;
}

2. Error Handling

Checklist:

[ ] All async operations have error handling
[ ] try/catch blocks used for risky operations
[ ] Errors are logged with context
[ ] User-facing errors are sanitized
[ ] Error messages are actionable
[ ] No silent failures (empty catch blocks)
[ ] Edge cases are handled (null, undefined, empty arrays)
[ ] Input validation exists for external data
[ ] Database operations handle connection failures
[ ] API calls have timeout handling