review-local

review-local

Review the user's current local php-src diff. Read-only. Produces REVIEW.md in pwd.

Inputs

1. $PHP_SRC_DIR — the php-src checkout.
2. Optional base ref — defaults to git merge-base HEAD origin/master. User can override (/review-local PHP-8.3).
3. The skill operates against the current branch in $PHP_SRC_DIR. It does NOT switch branches.

What it produces

• REVIEW.md in the task directory resolved per _shared/task-dir.md (default $PHP_SRC_DIR/.claude/php-core-dev/review-<short-base>/REVIEW.md) — severity-graded findings.
• If REVIEW.md exists from a prior run at the same path, it's backed up to REVIEW.md.bak before being overwritten.
• Slug: review-<short-sha> where <short-sha> is git rev-parse --short <base>. If the base is a branch (e.g. PHP-8.3 — any maintained branch from _shared/branch-detection.md), use review-<branch-slug> instead. Slug is written to .current.

Workflow

1. Pre-checks

test -n "$PHP_SRC_DIR" && test -d "$PHP_SRC_DIR/Zend" || { echo "Run /install"; exit 1; }
cd "$PHP_SRC_DIR"
git status --porcelain          # warn (don't block) if dirty

If the working tree is dirty, note it in REVIEW.md's Scope section — uncommitted changes are part of the diff to review.

2. Determine base ref

BASE=$(git merge-base HEAD origin/master 2>/dev/null || git merge-base HEAD master)

If the user passed an explicit base (PHP-8.3, a SHA, etc.), use that.

If no base can be determined (no master, no origin), stop with:

Cannot determine review base. Pass one explicitly: /review-local <base-ref>

3. Pull the diff

git -C "$PHP_SRC_DIR" diff "$BASE"...HEAD --stat
git -C "$PHP_SRC_DIR" diff "$BASE"...HEAD

Capture:

• Files changed (count, paths)
• Lines added / removed (from --stat)
• The full unified diff (for analysis)

If the diff is empty, stop with No changes between $BASE and HEAD — nothing to review.

4. Backup existing REVIEW.md