fundamental-styles: Skill for Claude Code

PR Review: #$0

Perform a comprehensive review of pull request #$0 in the fundamental-styles repository, checking against project coding standards, accessibility requirements, and architectural patterns.

Setup

If $0 is empty or not a number, ask the user for a PR number before proceeding.

Fetch PR Context

Gather all necessary information about the PR:

# PR metadata and description
gh pr view $0 --json title,body,author,state,isDraft,labels

# Full diff for review
gh pr diff $0

# List of changed files
gh pr diff $0 --name-only

Review Checklist

Review each changed file against the applicable sections below. Report findings grouped by severity:

• Blocking: Must fix before merge (breaks functionality, violates critical standards)
• Suggestion: Should fix (best practices, maintainability)
• Nit: Optional improvements (style preferences, minor optimizations)

1. Commit & PR Format

Verify commit messages and PR title follow the conventional format:

Expected format: <type>(<scope>): <subject>

Valid types:

• feat - New feature or component
• fix - Bug fix
• docs - Documentation changes
• style - CSS/SCSS styling changes (not code style)
• refactor - Code refactoring without behavior change
• test - Adding or updating tests
• build - Build system or dependency changes
• ci - CI/CD configuration changes
• chore - Maintenance tasks

Valid scopes:

• styles - SCSS/CSS changes
• docs - Documentation
• ci - CI/CD
• Component names (e.g., button, card, table)

Rules:

• PR title follows format
• Commit messages follow format
• No WIP prefix unless marked as draft
• Scope is specific and accurate

2. SCSS Code Style (for *.scss files)

Check against .claude/skills/scss-style-guide.md standards:

BEM Naming

• Block variable defined: $block: #{$fd-namespace}-component-name;
• Block classes: .#{$block}
• Element classes: .#{$block}__element
• Modifier classes: .#{$block}--modifier
• No deviations from strict BEM pattern