forge-quench

Forge Quench — Code Simplification Skill

Named after the metallurgical quenching process — rapidly cooling hot metal simplifies its crystal structure and hardens it.

Trigger

"Simplify this code" / "Reduce complexity" / "Clean up before review" / "Quench this module" / "Code is too complex"

Steps

1. Measure Complexity

Identify the most complex methods in the target files. Use .NET-appropriate static analysis:

# Install dotnet-counters for runtime diagnostics (optional)
dotnet tool install -g dotnet-counters

# Count methods exceeding 50 lines
grep -rn "public\|private\|protected\|internal" <target> --include="*.cs" | head -30

# Check cyclomatic complexity via JetBrains dotnet-inspect if available
# dotnet-inspect <target> --severity=WARNING

# Manual analysis: identify deep nesting, long switch statements, excessive branching
grep -rn "if\|else\|switch\|case\|catch" <target> --include="*.cs" | wc -l

List the top 3–5 most complex methods by:

• Line count (methods >50 lines)
• Nesting depth (>3 levels of indentation)
• Branch count (>5 if/else/switch branches)
• Parameter count (>4 parameters)

If no methods exceed thresholds: Report "No simplification candidates found" and STOP with a PASS.

2. Understand First (Chesterton's Fence)

Before simplifying ANY code, document WHY the complexity exists.

For each candidate function:

1. Read the git blame to find when and why it was written
2. Check if comments explain the reasoning
3. Look for edge cases the complexity handles (null checks, retry logic, fallback paths)
4. Document your understanding in a brief note

| Function | Lines | Why Complex | Still Valid? | Action |
|----------|-------|-------------|-------------|--------|
| processOrder() | 87 | Handles 3 payment providers + retry | Yes — 3 providers still active | Simplify: extract per-provider strategies |
| validateInput() | 62 | Legacy regex for 5 country formats | Partially — 2 formats deprecated | Simplify: remove deprecated formats |
| buildReport() | 45 | Single function, low nesting | N/A — not complex enough | Skip |