review-pr

Review Pull Request

Answers the craft question: "is this code well-built?" Covers code quality, architecture, security, tests, and operational concerns as static inspection. It does not build or run the code (that is /verify-pr's conformance role) and does not judge whether the target is the right product (that is /validate-pr's validation role). Findings about whether the criteria are met go to /verify-pr; findings about whether the right problem is solved go to /validate-pr. Writes findings to a structured markdown file.

Prerequisites

• Apply the shared SDLC conventions in skills/sdlc/references/shared.md.
• If no argument is provided, target the pull request from $PR_NUMBER (and $REPO).
• gh CLI authenticated with read access to the target repository
• git worktree available
• PR number ($1) identifying an open pull request

Skill attribution (GitHub)

Before posting to GitHub, read ../github-post-attribution/SKILL.md and append the footer for SKILL_DIR = review-pr.

Workflow

Fetch PR metadata + comments ($1)
            |
            v
  Create git worktree on PR branch
            |
            v
  Pre-Review Checklist
  (build, metadata, objective)
            |
            v
  Code Review Checklist
  (quality, tests, architecture,
   ops, security, docs)
            |
            v
  Context-Specific Review
  (feature / bug fix / DB / API?)
            |
            v
  Write review-pr.$SHORT_SHA.md
  (create or update)
             |
             v
   Post review file
   as PR comment
   (gated by should-post-to-github)

Setup

Fetch PR information by piping the raw ghx output directly to a file (do not generate or summarize the content). PR review reports resolve to $HOME/.sdlc/$REPO/pull-requests/$PR_NUMBER/ per sdlc/references/shared.md (PR Review Reports):

PR_REVIEW_DIR="$HOME/.sdlc/$REPO/pull-requests/$PR_NUMBER"
mkdir -p "$PR_REVIEW_DIR"
ghx pr view $1 --repo "$REPO" --comments --refresh > "$PR_REVIEW_DIR/gh-pr-view.md"