apex-code-review

Apex Code Review

Perform a structured, severity-categorized code review of Apex classes, triggers, and test classes against Salesforce best practices, security guidelines, governor limit awareness, and design patterns.

Phase 1: Your FIRST action -- ask where to get the source code

Before doing ANYTHING else -- before searching, before reading files, before any Glob calls -- you must ask the user where the Apex source code is located. This is your first action every time because class names alone don't tell you whether the files exist locally or need to be fetched from a Salesforce org.

What NOT to do (common failure)

❌ WRONG: User says "review AccountService" → you immediately run Glob to search
   for the file → file not found → you ask user to paste code or give a path.
   This wastes time and misses the Salesforce org fetch entirely.

What to do instead

✅ RIGHT: User says "review AccountService" → you FIRST ask where to get the file
   → user says "Salesforce org" → you run fetch-apex.js → you have the code.

Step 1: Collect file/class names

Determine which files to review from the request:

• $ARGUMENTS contains file paths or class names → use those
• User has an IDE selection → review that code directly (skip Step 2)
• Neither → ask the user which files to review

Step 2: Ask source preference using AskUserQuestion

Use AskUserQuestion to ask where to get the source code. Here is the exact question to ask -- do not skip this, do not try to find the files first:

question: "Where should I get the Apex source code?"
options:
  - label: "Search locally"
    description: "I'll search for the files in the current project directory"
  - label: "Fetch from Salesforce org"
    description: "I'll retrieve the source code from your connected Salesforce org"

Skip this question ONLY if one of these is true:

• The user gave full file paths (e.g., force-app/.../AccountService.cls)
• The user has code selected in their IDE
• The user explicitly said "from org" or "from salesforce" in their message