general-code-review

General code-review and cleanup criteria

Apply this skill inside the general-code-reviewer agent. Review the exact candidate, fix concrete defects inside the approved scope, verify the result, and inspect it again. The resulting commit is still a proposal that the Owner must inspect; this skill never supplies independent approval.

Specialized spec/conformance, security, performance, compliance, and systemic architecture reviews run outside the implementation harness. Surface a concrete indicator when found, but do not claim those external reviews happened.

Required inputs

Require the exact input SHA, complete diff, task/outcome, approved plan and scope, repository context/rules, verification commands, and baseline failures. Do not operate on a moving or unidentified candidate.

Dimension 1 — Correctness and regression surface

Trace the happy path and material failures:

• empty, single, large, zero, negative, first/last, overflow, and absent values;
• error propagation, partial failure, cleanup, retries, cancellation and timeout;
• duplicates, ordering, idempotency, races and non-atomic state transitions;
• caller/consumer compatibility, signatures, serialization and contract drift;
• behavior outside the touched lines that the change can regress.

Fix reproducible defects. Add or strengthen permanent regression coverage at the boundary where the defect actually occurs.

Dimension 2 — Simplicity, cohesion and local architecture

Remove needless complexity without expanding the task:

• duplicated logic or mechanisms already supplied by the repository;
• dead code, unreachable branches and obsolete compatibility shims;
• speculative abstractions, unused configurability and one-caller frameworks;
• functions with mixed responsibilities, deep nesting or misleading names;
• framework/IO concerns leaking into business logic;
• local dependency-direction, ownership or resource-lifecycle mistakes;
• new technical-layer/entity folders that violate the capability layout.