code-review

---

name: code-review description: Used when the user wants to review code, check quality, verify feature completeness, or needs to validate code implementation against Spec, DESIGN.md, and design mockups. Outputs a structured review report with evidence for each conclusion. version: 2.3.0 updated: 2026-07-16 requires: []

[Task] Review code implementation completeness and quality against Product-Spec.md, DESIGN.md (when present), and design mockups. Output a structured review report. Fixes are executed by the main Agent using dev-builder or bug-fixer Skill after receiving the report.

[Not For] - Fixing bugs -> use /bug-fixer instead - Writing new features -> use /dev-builder instead - Requirements gathering -> use /product-spec-builder instead

[Dependency Check] Automatically executed as the first step when the Skill starts:

Required:
- Product-Spec.md -> if missing, prompt to call /product-spec-builder first
- Project code exists -> if no code, prompt to call /dev-builder first

Optional (enhances review capability):
- `.forge/security-guidance.md` -> if present, **must read** for moderate/complex reviews or when `code-reviewer-security` runs
- DEV-PLAN.md -> if available, cross-reference Phase delivery checklist
- Design-Brief.md -> if available, cross-reference visual direction (direction only when DESIGN.md absent)
- DESIGN.md -> if available, cross-reference frozen tokens and components (priority over Brief for exact UI values)
- Design tool MCP -> if available, extract design values and compare with code (supplements DESIGN.md when both exist)
- Playwright plugin -> if available, automate UI interaction testing
- git -> if available, use git diff to trace change scope

[Shared Discipline] Review 时重点查 Surgical Changes + Simplicity First → ../_shared/karpathy-discipline.md 每条 finding 带 action（auto-fix/ask-user/no-op，谁来修）→ ../_shared/finding-actions.md

[First Principles] Review 前必读 references/first-principles.md Tech Stack: 审查前读 .forge/dev-map.md 的技术栈节，按语言选择审查维度（Java 侧重 import/异常/DI；Python 侧重 import/类型标注；JS/TS 侧重类型/async/import 路径）。 Code Standards: 审查时同时加载 .forge/code-standards/<language>.md，对照规范逐项检查（命名、异常处理、依赖注入模式等）。

[Output Style] → references/output-style.md

[File Structure] code-review/ ├── SKILL.md ├── commands/code-review.md └── references/ ├── first-principles.md ├── output-style.md ├── judgment-spectrum.md ├── anti-rationalization.md ├── anti-ai-slop-checklist.md ├── review-dimension-checklist.md ├── review-strategy.md ├── multi-perspective-dispatch.md # 4 维审查的平台无关分发（Mode A/B） ├── workflow.md # Step 1–5（必读） └── yolo-mode.md ../_shared/

[Output Artifacts] - Review report (screen output) — parallel agent review results with aggregated findings

[Judgment Spectrum] → references/judgment-spectrum.md

[Dimension Checklist] See references/review-dimension-checklist.md for the full review dimension checklist.

Must-have dimensions:
- **Functional Completeness**: every Spec requirement has a code implementation
- **Surgical Changes Audit**: every changed line traces to the original request
- **Simplicity First Audit**: no over-engineering or speculative abstraction
- **Security Scan**: hardcoded credentials, XSS, SQL injection, path leakage
- **Type Safety**: language-aware (TS `any`/`@ts-ignore`; other stacks per `code-standards` / types agent)
- **Performance (lightweight)**: N+1 / unbounded loops / hot-path sync I/O when visible in diff (owned by bug dimension)