optimizely-performance

Optimizely Performance Agent

Analyze content loading patterns, caching strategies, and performance anti-patterns.

Analysis Areas

1. Unbounded Content Loading

PERF-001: GetChildren Without Take() Limit (Critical)

Unbounded content queries can cause memory and performance issues:

Grep: GetChildren\s*<.*>\s*\([^)]*\)(?!.*Take)
Grep: GetDescendents\s*\(
Grep: GetAncestors\s*\(

Bad Pattern:

// Loads ALL children - could be thousands!
var children = _contentLoader.GetChildren<IContent>(parentLink);

// Even worse - recursive descendants
var allDescendants = _contentLoader.GetDescendents(startPage);

Good Pattern:

// Bounded query
var children = _contentLoader.GetChildren<ArticlePage>(parentLink)
    .OrderByDescending(x => x.StartPublish)
    .Take(10);

// Or use pagination
var pagedChildren = _contentLoader.GetChildren<ArticlePage>(parentLink)
    .Skip(page * pageSize)
    .Take(pageSize);

2. N+1 Content Loading

PERF-002: N+1 Content Loading in Loops (Critical)

Loading content inside loops causes many database roundtrips:

Grep: foreach.*\{[\s\S]*?GetContent\s*\(
Grep: for\s*\(.*\{[\s\S]*?GetContent\s*\(
Grep: \.Select\(.*GetContent

Bad Pattern:

var references = GetContentReferences();
foreach (var reference in references)
{
    // N+1 problem - one query per item!
    var content = _contentLoader.Get<IContent>(reference);
    Process(content);
}

Good Pattern:

var references = GetContentReferences();
// Single batch query
var contents = _contentLoader.GetItems(references, new LoaderOptions());
foreach (var content in contents)
{
    Process(content);
}

3. Content Loader Usage

PERF-003: Not Using IContentLoader (Warning)

IContentLoader provides caching; IContentRepository does not:

Grep: IContentRepository\.Get
Grep: _contentRepository\.Get

Prefer IContentLoader for reads:

// Good: Uses cache
var page = _contentLoader.Get<ArticlePage>(contentLink);

// Only use IContentRepository for write operations
_contentRepository.Save(page, SaveAction.Publish);