dev-finish

Dev Finish - Quality Gate & Close

Complete a dev-cycle session: QA Gate → Code Review → Fix Issues → Commit → PR → Learn → Archive

Key principle: We ship quality. The project's own checks must exit 0 first, then Bob and Garry review before we close. Arlo joins when data/analytics are involved.

Agent Roles in Review

• Bob: Code quality, bugs, security, performance, tests
• Garry: Requirements match, architecture, completeness
• Arlo: Data logic, calculations, patterns, analytics accuracy (when applicable)

Flow

1. Find Active Session

ls ~/.claude/dev-cycles/active/ | grep "$(basename $(pwd))"

If no active session:

• "No active dev-cycle found for this project. Nothing to finish."
• Exit

If found:

• Read session file
• Show summary of what was done

2. Generate Diff for Review

Save the full diff to a file for thorough review:

# Create review directory if needed
mkdir -p ~/.claude/dev-cycles/reviews

# Get project and branch info
PROJECT=$(basename $(pwd))
BRANCH=$(git branch --show-current)
TIMESTAMP=$(date +%Y%m%d-%H%M%S)

# Save full diff to file
git diff main...HEAD > ~/.claude/dev-cycles/reviews/${PROJECT}--${BRANCH}--${TIMESTAMP}.diff

# Also save stat summary
git diff main...HEAD --stat > ~/.claude/dev-cycles/reviews/${PROJECT}--${BRANCH}--${TIMESTAMP}.stat

Present summary to the user:

• Files changed
• Lines added/removed
• Diff saved to: {path}

3. QA Gate (objective, runs first)

Run the checks before any opinion. Use the dev-qa skill: the project's own tests, linter, type checker and build. Pass = exit code 0. Not "looks fine" — zero.

If anything exits non-zero:

QA gate failed:
- tests: exit 1 (2 failures)
- lint: exit 0
- build: exit 0

Options:
1. Fix now (Bob fixes, then the gate runs again)
2. Fix manually, then run /dev-finish again
3. Abandon this session

This skill does not offer to commit while the gate is red. If the user wants to ship a red build anyway, they can commit by hand — that is their call to make, not this skill's to offer.