fw-review

Scope

• Review of diffs, commits, or specific changed files in embedded C/C++ projects
• Bugs, behavioral regressions, runtime risks, concurrency, memory, and platform rule violations
• Changes outside firmware code (docs, CI, scripts, plans) — skip fw-context, review manually

CRITICAL — MANDATORY

For C/C++ source code, use ONLY fw-context tools for reading, searching, and browsing files. MUST NOT use any other tool to read or search C/C++ source. fw-context provides ifdef-filtered code — only what actually compiles for the active build configuration. Other tools show unprocessed preprocessor noise including dead #ifdef branches.

MUST NOT skip Phase 0. Every review MUST begin by creating and writing out the plan.

Core principle — verify in full project context

Every code change MUST be verified recursively against the entire project, not just the local diff fragment. A change that looks correct in isolation can be wrong in the broader context. For every changed symbol (function, type, macro):

• Callers — who calls this? Were they all updated? Use find_callers then find_all_callers_recursive for the full call tree.
• Callees — what does this call? Is the new behavior still compatible with downstream dependencies? Use get_symbol_context or find_callees_recursive.
• Users — who reads/writes this type or variable? Use find_references.
• Duplicates — does a similar implementation exist elsewhere? Use search_bodies and scan ALL results.
• Removals — is the removed symbol truly gone from every file? Use search_content to confirm zero results project-wide.
• Dead code — did the removal leave orphaned functions? Use find_dead_code.

The diff shows SCOPE. fw-context verifies CORRECTNESS. Never conclude a review from the diff alone.

Phase 0: Create a review plan (MANDATORY)

BEFORE any detailed analysis, classify EVERY changed file and build a checklist of fw-context tools to run against each changed symbol. This is the single most effective guard against missed checks.