godot-code-review

Godot Code Review

A structured review guide for Godot 4.3+ projects covering GDScript and C#. Work through each checklist section, then produce a review summary using the output template at the end.

Related skills: godot-testing for TDD and test coverage, scene-organization for scene tree best practices, godot-optimization for performance review.

---

1. Node & Scene Architecture

• Each scene has a single, clear responsibility (player, enemy, UI widget, etc.)
• Inheritance chains are shallow — prefer composition via child nodes over deep extends hierarchies
• Autoloads (singletons) are used sparingly; only truly global state belongs there
• Node references traverse only to direct children — no get_parent() chains
• @onready (GDScript) or GetNode<T>() (C#) targets direct children or named paths within the same scene

Anti-pattern — get_parent() chain

# BAD: tight coupling, breaks if the tree changes
func take_damage(amount: int) -> void:
    get_parent().get_parent().get_node("HUD").update_health(health)

// BAD: tight coupling, breaks if the tree changes
public void TakeDamage(int amount)
{
    GetParent().GetParent().GetNode("HUD").Call("UpdateHealth", _health);
}

Fix — emit a signal instead

# GOOD: parent/ancestor listens; child stays decoupled
signal health_changed(new_health: int)

func take_damage(amount: int) -> void:
    health -= amount
    health_changed.emit(health)

// GOOD: parent/ancestor listens; child stays decoupled
[Signal]
public delegate void HealthChangedEventHandler(int newHealth);

public void TakeDamage(int amount)
{
    _health -= amount;
    EmitSignal(SignalName.HealthChanged, _health);
}

---

2. GDScript Style

• Variables and functions use snake_case
• Class names declared with class_name use PascalCase
• Constants use SCREAMING_SNAKE_CASE
• All function parameters and return types carry type hints
• @export variables include an explicit type
• Signal declarations appear at the top of the file, before variables